Adam Milligan's blog



Adam MilliganAdam Milligan
Refactoring a dead horse
edit Posted by Adam Milligan on Sunday May 10, 2009 at 05:30PM

A while back I made the point that the HasOneThroughAssociation class in Rails shouldn't be a subclass of HasManyThroughAssociation. I also submitted a Rails patch in which I changed the superclass of HasOneThroughAssociation from HasManyThroughAssociation to HasOneAssociation and moved the shared Through functionality into a module. Despite support from the teeming millions, Rails core team member Pratik rejected the patch for being "just a refactoring."